Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve English translation #645

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Improve English translation #645

merged 1 commit into from
Apr 19, 2021

Conversation

ENDrain
Copy link
Contributor

@ENDrain ENDrain commented Apr 19, 2021

This improvement of English translation fixes the $ positioning in messages.

This is an update of #240 in case somebody still needs this.

@ImagicTheCat
Copy link
Member

I will merge it; there are two very minor issues:

  • Sometimes the color modifier is applied to the symbol, sometimes it is not. It's probably nicer to have it applied consistently.
  • Indent mistake at line 343.

It's better if you can rebase the PR. Thanks.

@ENDrain
Improve English translation
1d2c3ac 
Fix "$" position in messages
@ENDrain
Copy link
Contributor Author

ENDrain commented Apr 19, 2021

My apology, I wasn't careful enough. Hope I did better this time!

@ImagicTheCat ImagicTheCat merged commit 234105f into vRP-framework:master Apr 19, 2021
@ENDrain ENDrain deleted the translations branch April 20, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ENDrain @ImagicTheCat